Re-add arguments check for v8 function bindings#194
Merged
martinweismann merged 13 commits intoAutodesk:JSImplfrom Jul 20, 2023
Merged
Re-add arguments check for v8 function bindings#194martinweismann merged 13 commits intoAutodesk:JSImplfrom
martinweismann merged 13 commits intoAutodesk:JSImplfrom
Conversation
| @@ -0,0 +1,3 @@ | |||
| module Source | |||
Member
There was a problem hiding this comment.
what's that file doing here? :)
Collaborator
Author
There was a problem hiding this comment.
When I added a go extension to VSCode for a bit of help it complained until I added one of these.
Collaborator
Author
There was a problem hiding this comment.
I didn't think it would do any harm to submit and it may save someone some time setting up.
Member
|
Where do all the formatting changes come from? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The check for the correct number of arguments was removed (sorry) with the work to introduce properties.
This adds the check back in and, now, only checks for [in] arguments instead of both [in] and [out] arguments.